-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gamepad, gamepadshift #4940
Conversation
Currently
So we need to turn it back on for some or all, especially those boards that depend on gamepad or gamepadshift for most of their use (e.g. pewpew boards) but there may be space issues for larger languages.
|
I've fixed build errors and explicitly enabled keypad on:
All other boards that HAD gamepad or gamepadshift seemed to already have keypad enabled. |
Before I added
I had to set that to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't merge this until all examples and libraries have been updated.
These are effectively replaced by the new keypad module, which is reenabled on select boards as well as when CIRCUITPY_FULL_BUILD is specified and it is not specifically disabled.
I'll re-disable gamepad whereever it doesn't fit based on the above builds, and then wait for the signal that this can be merged. |
i reviewed & merged #4942 |
These libraries are still using
Issues added to all these libraries. |
I will update #5059 or open a new PR to include parts of this. |
These are effectively replaced by the new keypad module (#4877)
@deshipu @ladyada