Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gamepad, gamepadshift #4940

Closed
wants to merge 2 commits into from
Closed

Conversation

jepler
Copy link
Member

@jepler jepler commented Jun 28, 2021

These are effectively replaced by the new keypad module (#4877)

@deshipu @ladyada

@dhalbert
Copy link
Collaborator

dhalbert commented Jun 28, 2021

Currently keypad is turned off for all SAMD21 builds:

CIRCUITPY_KEYPAD ?= 0

So we need to turn it back on for some or all, especially those boards that depend on gamepad or gamepadshift for most of their use (e.g. pewpew boards) but there may be space issues for larger languages.

@jepler
Copy link
Member Author

jepler commented Jun 28, 2021

I've fixed build errors and explicitly enabled keypad on:

  • 8086_commander
  • pewpew_m4
  • ugame10

All other boards that HAD gamepad or gamepadshift seemed to already have keypad enabled.

@dhalbert
Copy link
Collaborator

All other boards that HAD gamepad or gamepadshift seemed to already have keypad enabled.

Before I added keypad, pretty much all the SAMD21 CIRCUITPY_FULL_BUILD boards had gamepad, i.e. there was something like:

CIRCUITPY_GAMEPAD ?= $(CIRCUITPY_FULL_BUILD)

I had to set that to 0 for all SAMD21 to get the builds to fit. So if possible it would be good to put keypad back in the CIRCUITPY_FULL_BUILD

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge this until all examples and libraries have been updated.

These are effectively replaced by the new keypad module, which is
reenabled on select boards as well as when CIRCUITPY_FULL_BUILD is
specified and it is not specifically disabled.
@jepler
Copy link
Member Author

jepler commented Jun 29, 2021

I'll re-disable gamepad whereever it doesn't fit based on the above builds, and then wait for the signal that this can be merged.

@deshipu
Copy link

deshipu commented Jun 29, 2021

@jepler please don't disable gamepad on pewpew_m4 without first merging #4942 — the Stage library needs to be modified to use keypad.

@ladyada
Copy link
Member

ladyada commented Jun 29, 2021

i reviewed & merged #4942

@dhalbert
Copy link
Collaborator

dhalbert commented Jul 1, 2021

These libraries are still using gamepad or gamepadshift:

  • adafruit-circuitplayground, were_pressed(), and in conf.py
  • adafruit-pybadger
  • adafruit-cursorcontrol
  • adafruit-clue

Issues added to all these libraries.

@dhalbert
Copy link
Collaborator

I will update #5059 or open a new PR to include parts of this. gamepad and keypad together do not fit on some SAMD21 boards. But we'll leave gamepadshift in for 7.0.0 because it's harder to emulate, and not remove it until 8.0.0 after the libraries that use gamepadshift have been updated to use keypad.

@dhalbert dhalbert closed this Jul 26, 2021
@jepler jepler deleted the remove-gamepad branch July 27, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants