-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PortalBase and Fake Requests and update Frozen Libs on Portal boards #6043
Conversation
Hmm, it's failing with this error:
|
Nope, it's this error actually:
I probably froze it wrong. |
Make sure that the submodule is pointed exactly at a tagged release, not at the tip of main. |
I don't think I did that. How is that done? |
I went into the submodule and checked out the release tag for each and then committed for this PR. Hopefully that's right. |
@makermelissa If you go to the top level at |
It's too much for poor matrixportal to handle .. by a lot 😢
|
Ok, hmm. Now to figure out what to leave out. I did give it everything relevant to it. |
I removed DisplayText from MatrixPortal since it really contains 3 variations and only one is loaded in memory, but it uses 60k of frozen space. |
I tested compiling locally and it was still failing, so I removed a couple more frozen libs and disabled some modules that likely aren't used such as sharpdisplay, sdcardio, and bleio. If any of those are actually needed for the MatrixPortal, we can shuffle it around some more. |
Is the inclusion of FakeRequests unavoidable? well, I guess it's not very big... |
Correct.
Yeah, it's more of a convenience thing. We could remove it if you think that's be better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! It's too bad we have to do this even on these big chips, but there's a lot of code.
Agreed, I think optimizing the portal libraries would help. I have an issue open to do that. |
This will free up some memory on a few of the boards that use the PortalBase library, which currently does not function on the MatrixPortal and is pretty close to the max space on the others.