Fix getenv_int handling of "dos-style" newlines #7395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iants .. of getenv. These can have their own special bugs.
This is a small optimization, it avoids reading the full file when an early key is requested. In the case of an *invalid* TOML file such as ``` K=80 K=81 ``` this stops the value of K actually returned being 8081 and makes it 80 instead; but as it's a malformed file it doesn't really matter much.
dhalbert
approved these changes
Dec 28, 2022
There was a problem hiding this comment.
Looks good to me, including the test coverage. @rsbohn and @grbd, would you like to test? The build artifacts will be on this page in a little while: https://github.com/adafruit/circuitpython/actions/runs/3796145570
|
Tested, working on Adafruit CircuitPython 8.0.0-beta.6-8-g8241edd52 on 2022-12-28; FeatherS2 with ESP32S2. |
|
Thanks for the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this closes #7380 ; closes #7394.