Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getenv_int handling of "dos-style" newlines #7395

Merged
merged 5 commits into from
Dec 28, 2022
Merged

Fix getenv_int handling of "dos-style" newlines #7395

merged 5 commits into from
Dec 28, 2022

Commits on Dec 28, 2022

  1. These need to be double-blackslashed

    @jepler
    jepler committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    edcb832 View commit details
    Browse the repository at this point in the history

  2. Allow the tests to directly call the non-heap using _int and _str var… 

    …iants

.. of getenv. These can have their own special bugs.
    @jepler
    jepler committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    83bbfd1 View commit details
    Browse the repository at this point in the history

  3. Permit trailing whitespace in getenv_int

    @jepler
    jepler committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    15a24b4 View commit details
    Browse the repository at this point in the history

  4. update test results

    @jepler
    jepler committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    2c46e78 View commit details
    Browse the repository at this point in the history

  5. break out after reading the value 

    This is a small optimization, it avoids reading the full file when an
early key is requested.

In the case of an *invalid* TOML file such as
```
K=80
K=81
```
this stops the value of K actually returned being 8081 and makes it 80
instead; but as it's a malformed file it doesn't really matter much.
    @jepler
    jepler committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    7a005aa View commit details
    Browse the repository at this point in the history