Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor espressif CI #7420

Closed
wants to merge 1 commit into from
Closed

Refactor espressif CI #7420

wants to merge 1 commit into from

Conversation

microdev1
Copy link
Collaborator

@microdev1 microdev1 commented Jan 5, 2023

This will install toolchain specific to the chip on an espressif board.
See #7420 (comment).

@jepler
Copy link
Member

jepler commented Jan 5, 2023

how does this interact with the idf tools cache? For instance, if the cache is created from an xtensa build, will it fail to cache the riscv toolchain, thus causing all riscv toolchain builds to have to fetch from the remote network instead of from cache?

@tannewt tannewt requested a review from jepler January 5, 2023 19:27
@microdev1
Copy link
Collaborator Author

I completely forgot about the cache, I am not sure how this change will interact with it and I won't give it much thought as the cache makes this change pointless as there is no performance improvement.

I can alter this PR and just keep the slight refactoring stuff or this can be closed.

@microdev1 microdev1 changed the title Install target specific idf tools Refactor espressif CI Jan 5, 2023
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I have a question.

.github/workflows/build.yml Show resolved Hide resolved
@microdev1
Copy link
Collaborator Author

Changes moved to PR 7428.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants