New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple CI Enhancements #7428
Multiple CI Enhancements #7428
Conversation
- avoid `github.event.after` as it isn't available during initial CI run of the PR
[I've removed myself as a reviewer. I find this stuff difficult to reason about and as a result I end up being unfairly negative about such changes] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Should we set this as a draft for now, since you're still tuning it?
I am still interested in using partial clones, either treeless or blobless. They transparently appear to contain the entire commit history but don't fetch everything. Fetches are done on demand, as necessary. I think it may eliminate the depth calculations, and perhaps remove the need to do github API calls, because the info is all local (not sure about that).
Have you looked at https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone/ and related material? Quoting, emphasis mine:
- git clone --filter=blob:none creates a blobless clone. These clones download all reachable commits and trees while fetching blobs on-demand. These clones are best for developers and build environments that span multiple builds.
- git clone --filter=tree:0 creates a treeless clone. These clones download all reachable commits while fetching trees and blobs on-demand. These clones are best for build environments where the repository will be deleted after a single build, but you still need access to commit history.
- git clone --depth=1 creates a shallow clone. These clones truncate the commit history to reduce the clone size. This creates some unexpected behavior issues, limiting which Git commands are possible. These clones also put undue stress on later fetches, so they are strongly discouraged for developer use. They are helpful for some build environments where the repository will be deleted after a single build.
This should be good to merge now.
The |
@microdev1 what did you just change? |
Nothing! I am experimenting with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's try this! Thanks!
This contains the following CI enhancements:
ci_changes_per_commit.py
:checkrun
->check_run
checksuite
->check_suite
fatal: error in object: unshallow
which occurs sometimes post runninggit fetch --shallow-since
.//|
matches in*.c
files.espressif
CI #7420.