espressif: Set socket type on accepted socket #8932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, https serving "works for me" on a matrixportal s3 with a modified version of https://github.com/ide/circuitpython-https-server/ (it bundles mpy files incompatible with cpy9 and is not compatible with current adafruit_httpserver); a PR to circuitpython-https-server will also be forthcoming
|
|
related work but I don't think it's necessary to have https work right: adafruit/Adafruit_CircuitPython_HTTPServer#82 |
|
Updated circuitpython-https-server at ide/circuitpython-https-server#2 |
dhalbert
approved these changes
Feb 16, 2024
ide
pushed a commit
to ide/circuitpython-https-server
that referenced
this pull request
Feb 20, 2024
Together with adafruit/circuitpython#8932 this https server is verified to work on `Adafruit MatrixPortal S3 with ESP32S3 running 9.0.0-beta.0-38-g0c3b62fac2-dirty on 2024-02-16`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, https serving "works for me" on a matrixportal s3 with a modified version of
https://github.com/ide/circuitpython-https-server/ (it bundles mpy files incompatible with cpy9 and is not compatible with current adafruit_httpserver); a PR to circuitpython-https-server will also be forthcoming