Update to current adafruit_httpserver & make response dynamic #2
Conversation
The bundled httpserver was old and its mpy format was not compatible with circuitpython 9
Now it'll name the specific device and version in the returned (text/plain) content.
scripts/deploy.sh
Outdated
| @@ -24,8 +24,12 @@ fi | |||
| echo "Found device at $device_path" | |||
|
|
|||
| echo 'Copying application code...' | |||
| rsync --verbose --recursive --delete --checksum \ | |||
| rsync --verbose --recursive --delete --checksum -@2 \ | |||
There was a problem hiding this comment.
What does the 2 do? Also prefer to use longhand notation for flags over shorthand in scripts for self-documentation.
There was a problem hiding this comment.
This improves detecting that a file is unchanged via timestamps, and speeds up rsync as a result (though it may also need --times so that the target timestamp is set to the source timestamp).
It should be -@1 or --modify-window=1, not 2. from man rsync:
--modify-window=NUM, -@
When comparing two timestamps, rsync treats the timestamps as
being equal if they differ by no more than the modify-window
value. The default is 0, which matches just integer seconds.
If you specify a negative value (and the receiver is at least
version 3.1.3) then nanoseconds will also be taken into account.
Specifying 1 is useful for copies to/from MS Windows FAT
filesystems, because FAT represents times with a 2-second reso‐
lution (allowing times to differ from the original by up to 1
second).
There was a problem hiding this comment.
Gotcha, please use --modify-window instead of -@
Co-authored-by: James Ide <ide@users.noreply.github.com>
I don't think circup supports installing a specific library by version, it only installs from the "latest bundle". So, the alternatives would seem to be to allow the version to be "whatever circup does", or to vendor a new version of the files. Is it OK if I update this PR to include adafruit_httpserver as 9.x mpy files instead? |
|
IME circup supports requirements.txt, take a look at |
.. generated by "circup freeze"
Together with adafruit/circuitpython#8932 this https server is verified to work on
Adafruit MatrixPortal S3 with ESP32S3 running 9.0.0-beta.0-38-g0c3b62fac2-dirty on 2024-02-16.