-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library gets updated even if update not needed. #165
Comments
Please update to the latest circup, though I don't think that may fix this. There may be something wrong with those two libraries. How about removing everything in |
@dhalbert some of the libraries were missing the version information, so circup incorrectly reported. However, I thought this adafruit/Adafruit_CircuitPython_DisplayIO_Layout#79 would have fixed the issue with displayio_layout. @b-blake could you check again, during my tests once displayio_layout was updated to the newest version, circup did not complain. tks :) |
At least two of the MCU have new libraries. When I start a new project I get the current library bundle and copy the entire thing into the lib folder (if space available). Being that the batch output says it was updated, I trust that it was updated. I will look at updating to 1.1.4 from 1.1.3. I would expect that if the issue I am seeing had been fixed in 1.1.4 it would be listed in the 'bug fixes' list. Off I go to find 1.1.4. Bruce |
Hi, I downloaded todays 20230320 compressed full library. I copied the entire thing into J:, K:, and M:. I then ran my script twice. The result is below. There are both new and old files that get a second probably unnecessary update. Found 1 module[s] needing update. Found 3 module[s] needing update. Found 2 module[s] needing update. etc. I have not found an update file for 1.1.4. What am I missing? Bruce
|
[Use triple backticks on their own lines to mark multiple lines of code. (Edit your posts above and see what I did.)] To upgrade What are If you just have one board attached, do you see the same problem? |
Since it seems confined to
I think this may be a library problem, not a circup problem. |
ill do some test on displayio this week to see what is going on.. |
Hi, If I update one device I get the same result that device gave before. ansi_escape_code gets updated and may be a clue. Bruce
|
Thanks @b-blake. |
@b-blake circup 1.1.15 (just released) will solve the issue for the displayio_layout. I have tested the changes. For the VL5311x library I have made a PR, once it is merged this will be fixed adafruit/Adafruit_CircuitPython_VL53L1X#15 |
Hi, I updated to 1.1.5. We now only have two libraries to beat into submission by my reckoning. They may already be pinned to the mat in 1.1.6. Second run at: 11:45 AM EDT. ansi_escape_code.mpy The results below are from a run less than 5 minutes after the first run for today, both runs with version 1.1.5. Bruce
|
Hello That is good, two things, I have made a PR for the font_maker.py here adafruit/Adafruit_CircuitPython_GFX#32 However, the Ansi_escape_code is a community library, and is supported by community members. As mentioned in the error message, the issue should be submitted to the Library Repo, and not in the circup library. I have submitted a PR in the community library s-light/CircuitPython_ansi_escape_code#2, but it will depend on the library owner, when the PR will be merged. I recommend following this PR, for this :) |
J,
Thank you for doing the PR for both items. "community library" did not
ring a bell for me to know to go to the community library to file the
issue. Not knowing the AdaFruit organizational structure it was a
difference without a difference. I promise you I will not be any smarter
next time, but I will try.
Bruce
P.S. FYI - I am not the young sports car you think I am.
This chassis was built in 1947 and has had major repairs, and the paint is
flaking off ;-)
.
…On Tue, Mar 21, 2023 at 12:41 PM jposada202020 ***@***.***> wrote:
Hello That is good, two things, I have made a PR for the font_maker.py
here adafruit/Adafruit_CircuitPython_GFX#32
<adafruit/Adafruit_CircuitPython_GFX#32>
However, the Ansi_escape_code is a community library, and is supported by
community members. As mentioned in the error message, the issue should be
submitted to the Library Repo, and not in the circup library.
I have submitted a PR in the community library
s-light/CircuitPython_ansi_escape_code#2
<s-light/CircuitPython_ansi_escape_code#2>, but
it will depend on the library owner, when the PR will be merged. I
recommend following this PR, for this :)
—
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWCPQOMQNNOXA7J2OPEHOSDW5HK25ANCNFSM6AAAAAAWBUIOT4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No worries :). 1947 seems like a good year :). FYI the community libraries are libraries maintained by community members, for a complete list of the 100: https://github.com/adafruit/CircuitPython_Community_Bundle/blob/main/circuitpython_community_library_list.md maybe you will find something that you could use in the future. Cheers :) |
Hello, I just ran CIRCUP twice on the same device with 9.0.0 Beta 0 loaded. All 330 library files were updated both times. Do I need to wait for something else to be updated before I try again? |
You need to update to the 1.5.3 release, which I created a few minutes ago. So do |
Updated and it works. |
Hello,
Updated adafruit_vl53l1x
Updated adafruit_displayio_layout
The above libraries get updated each time I run circup.exe on a board that has them. They get updated if they were last updated 5 minutes ago or 5 weeks ago. I have attached the output below of the batch file that with one click I can update 8 AfaFruit CircuitPython projects. The same script was run just a few minutes before.
Bruce
The text was updated successfully, but these errors were encountered: