Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mpy version checking for Circuitpython 9 #198

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

dhalbert
Copy link
Contributor

Fixes #165.
Fixes #196.

  • Handle .mpy files with bytecode version C\x06. The __version__ string is not findable in as straightforward a way because the way dictionary entries are in the .mpy has changed, so just look for the first string that looks like a version number.

Tested on 8.2.9 and 9.0.0-beta.0, including upgrading and downgrading between those versions.

@dhalbert dhalbert requested a review from a team February 13, 2024 20:50
@dhalbert
Copy link
Contributor Author

@b-blake I think this will fix your issues with updating.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@tannewt tannewt merged commit b260142 into adafruit:main Feb 13, 2024
1 check passed
FoamyGuy added a commit to vladak/circup that referenced this pull request Feb 26, 2024
@dhalbert dhalbert deleted the fix-mpy-update-checking branch March 3, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants