Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add platform entry for 8mpy #145

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Conversation

FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Jun 6, 2022

This allows circup to successfully install currently distributed library mpy files onto devices that report 8.0.0 based version strings in their boot_out.txt file such as building from main or current open PR branches.

Tested successfully by installing a library on PyPortal Titano with a custom build from a PR:

Adafruit CircuitPython 8.0.0-alpha.0-2-gffc451b33-dirty on 2022-06-04; Adafruit PyPortal Titano with samd51j20
Board ID:pyportal_titano

@FoamyGuy FoamyGuy requested a review from a team June 6, 2022 16:21
@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Jun 6, 2022

Latest commit updates the versions of tools specified in pre-commit config to match the ones used in standard libraries.

@dhalbert
Copy link
Contributor

dhalbert commented Jun 6, 2022

We can start building 8.x bundles too.

@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented Jun 6, 2022

I'm not sure of the exact root caused of actions failure. It may be trying to download or access an 8mpy bundle that doesn't actually exist due to my addition.

Unsure about correct way to resolve it. Perhaps building the 8.x bundle like you mentioned will cause that step to succeed?

@tekktrik
Copy link
Member

tekktrik commented Jun 6, 2022

I thiiiiiiink it's getting mad that there are now 3 bundles and the test says it should expect 2:

_bundle_count = 2

@tekktrik
Copy link
Member

tekktrik commented Jun 6, 2022

It correctly gets that there are 3 bundles and so fails the assert statement. So _bundle_count should be raised to 3 then manually?

@tekktrik
Copy link
Member

tekktrik commented Jun 6, 2022

You love to see it 🥳

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made _bundle_count in the test be based on circup.PLATFORMS, so we don't have to keep changing it.

Thanks for the fix!

@dhalbert dhalbert merged commit 2c23dd4 into adafruit:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants