-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add platform entry for 8mpy #145
Conversation
Latest commit updates the versions of tools specified in pre-commit config to match the ones used in standard libraries. |
We can start building 8.x bundles too. |
I'm not sure of the exact root caused of actions failure. It may be trying to download or access an 8mpy bundle that doesn't actually exist due to my addition. Unsure about correct way to resolve it. Perhaps building the 8.x bundle like you mentioned will cause that step to succeed? |
I thiiiiiiink it's getting mad that there are now 3 bundles and the test says it should expect 2: Line 934 in 86ff01c
|
It correctly gets that there are 3 bundles and so fails the |
You love to see it 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made _bundle_count
in the test be based on circup.PLATFORMS
, so we don't have to keep changing it.
Thanks for the fix!
This allows circup to successfully install currently distributed library mpy files onto devices that report 8.0.0 based version strings in their boot_out.txt file such as building from main or current open PR branches.
Tested successfully by installing a library on PyPortal Titano with a custom build from a PR: