Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pinned importlib_metadata version #149

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Jul 5, 2022

Looks like the currently pinned version of importlib_metadata is incompatible with setuptools, so this re-pins it to a newly updated version. Not entirely sure what the full ramifications of this are (from 0.20 to 4.12), to be honest, though it looks like, at a glance, our specific use of importlib_metadata.version() is unchanged between versions, from any kind of API breaking change.

@tekktrik tekktrik requested a review from a team July 5, 2022 03:42
Copy link
Contributor

@Neradoc Neradoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circup runs fine, docs run fine, CI passes, LGTM.

@tekktrik tekktrik merged commit b931a20 into adafruit:main Jul 5, 2022
@tekktrik tekktrik deleted the dev/fix-incompatibility branch February 14, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants