Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Local Path Install #216

Merged
merged 4 commits into from
May 12, 2024
Merged

Support Local Path Install #216

merged 4 commits into from
May 12, 2024

Conversation

FoamyGuy
Copy link
Contributor

This allows local filepaths to be passed to circup install instead of libraries that exist in a bundle.

So it becomes possible to do something like:

circup install synth_tools

which will install the local module at the directory synth_tools/ if it exists (or print an error if not).

That makes it so that circup can be used to install libraries that are not in any bundle but still shared in git repositories or other ways.

@todbot was one person interested in this functionality. If you have the opportunity to test this it's much appreciated.

circup/backends.py Outdated Show resolved Hide resolved
@FoamyGuy
Copy link
Contributor Author

I also added tab completion with glob.glob for the install command so that it will suggest existing local files based on the partial match.

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will be convenient!

@dhalbert dhalbert merged commit eacc319 into adafruit:main May 12, 2024
1 check passed
@dhalbert
Copy link
Contributor

@todbot I merged, but forgot to ask you if you wanted to test.

@todbot
Copy link

todbot commented May 12, 2024

@todbot I merged, but forgot to ask you if you wanted to test.

Got to this late, but this is great! Thanks! I think this will make installing larger projects much easier, for situations where we can't distribute a UF2 or have access to bundlefly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants