Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 65 - Multi module install #67

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Conversation

askpatrickw
Copy link
Contributor

@askpatrickw askpatrickw commented Jan 20, 2021

Fixes #65

This was pretty straight-forward.

Using the nargs parameter of the click.arguments allows you accept more than one library and then it is just iterating over that tuple. As I was re-reviewing this to update the readme, I see the uninstall already had this.

I tested install and uninstall with a single package and 4 packages, --verbose --py as well.

@askpatrickw askpatrickw requested a review from a team January 20, 2021 08:46
@makermelissa
Copy link
Contributor

I'll take a look at his here in just a bit.

Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Thanks for adding.

@makermelissa makermelissa merged commit 32d3a31 into adafruit:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

circup install should support more than one package at a time
2 participants