Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gh action #61

Merged
merged 4 commits into from
Dec 13, 2023
Merged

add gh action #61

merged 4 commits into from
Dec 13, 2023

Conversation

hathach
Copy link
Member

@hathach hathach commented Dec 12, 2023

This repo use rather old IDF v3.3.1, which can cause trouble for some to build. Although I have no issue on Linux, having gh ci build and upload bin file as commit & release artifacts is a nice addition. This will help to safe check changes.

Also take the chance to reudce firmware version duplicaiton

  • combine.py extract version from CommandHandler.cpp
  • make load-nina use wildcard to load bin file

@hathach hathach changed the title try to add gh action add gh action Dec 12, 2023
@hathach hathach marked this pull request as ready for review December 12, 2023 11:21
- combine.py extract version from CommandHandler.cpp
- make load-nina use wildcard to load bin file
Copy link

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In the long run, it would be great to generate version info automatically from the git tag, as is done here:
https://github.com/adafruit/circuitpython/blob/main/py/makeversionhdr.py

@hathach
Copy link
Member Author

hathach commented Dec 13, 2023

Thanks!

In the long run, it would be great to generate version info automatically from the git tag, as is done here: https://github.com/adafruit/circuitpython/blob/main/py/makeversionhdr.py

we can take a look at that later, though I am not sure if we could pass addtional option to arduino IDE.

@hathach hathach merged commit 42f4766 into master Dec 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants