-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get roots.pem from adafruit/certificates repo #57
Conversation
👍 |
@dhalbert I didn't do any rebase/merge with upstream yet, though building with this PR got it running with my pyportal m4 using your sketch WiFiSSLClient_AirLift_metro_m4.zip, server:
|
That is very odd, because the exact same thing with I wonder if it is something geographical, though I'm not sure why that would happen. |
@dhalbert you can use the artifact one in this commit, I have teseted it (as well as my local bin). https://github.com/adafruit/nina-fw/actions/runs/7190435237 |
10c6905
to
c895779
Compare
CI build artifact tested on Metro M4 AirLift Lite. Works fine with https://github.com/adafruit/nina-fw/files/13656309/WiFiSSLClient_AirLift_metro_m4.zip above with host I plan to release it as 1.7.7 when it's merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read over changes to combine.py, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhalbert great, we should merge and release this first. Though I will just merge so that we could move on with syncing nina-fw with upstream and also try to upgrade IDF to v5. Will let you decide when to make an release (just in case you want to have any pending/more changes)
Fixes #55.
roots.pem
from https://github.com/adafruit/certificates, which is a submodule.roots.pem
to save space.combine.py
withblack
.Awaiting testing by @crhuber from #55.