Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FireBeetle 2 ESP32-S3 #361

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Add FireBeetle 2 ESP32-S3 #361

merged 3 commits into from
Nov 16, 2023

Conversation

bill88t
Copy link
Contributor

@bill88t bill88t commented Nov 16, 2023

Checklist

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

  • If you are adding an new boards, please make sure
    • Provide link to your allocated VID/PID if applicable
    • Add your board to action ci in correct workflow and alphabet order for release binary
    • UF2_BOARD_ID in your board.h follow correct format from uf2 specs

This checklist items that are not applicable to your PR can be deleted.


The usb vid/pid was provided via email. I can provide the eml file if requested.

image

The artifact was tested.

I was pretty sure n16r8 modules used to be qio-only, but this board has a revised module on it (revision v0.1), and it seems to work with opi just fine. Switched back to qio just in case.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all is good, let me know if we can merge it now, or you want to make more update ?

@bill88t
Copy link
Contributor Author

bill88t commented Nov 16, 2023

Nope it's good. I loaded CP with it just fine!

@hathach hathach merged commit 775e059 into adafruit:master Nov 16, 2023
109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants