Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LILYGO T-Watch-S3 #399

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Add LILYGO T-Watch-S3 #399

merged 3 commits into from
Aug 5, 2024

Conversation

bill88t
Copy link
Contributor

@bill88t bill88t commented Aug 3, 2024

Checklist

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

  • Please provide specific title of the PR describing the change
  • If you are adding an new boards, please make sure
    • Provide link to your allocated VID/PID if applicable
    • UF2_BOARD_ID in your board.h follow correct format from uf2 specs

This checklist items that are not applicable to your PR can be deleted.


Description of Change

Board added: LILYGO T-Watch-S3

Pending USB VID PR: espressif/usb-pids#168
CircuitPython PR: adafruit/circuitpython#9480

The display is working as intended, however I do not know how to define rotation.

Note: I am not affiliated with the manufacturer.

@bill88t bill88t marked this pull request as draft August 4, 2024 17:33
@bill88t bill88t marked this pull request as ready for review August 5, 2024 15:41
@bill88t
Copy link
Contributor Author

bill88t commented Aug 5, 2024

The USB VID PR got merged.

This PR is ready, however if there is a way to rotate the display, please let me know.

@tannewt
Copy link
Member

tannewt commented Aug 5, 2024

The display is working as intended, however I do not know how to define rotation.

I suspect it is done through the MADCTRL define. You'll want to look in the ST7789V datasheet for how to set that value. Want me to merge before you sort that out?

@bill88t
Copy link
Contributor Author

bill88t commented Aug 5, 2024

No, there isn't a reason to rush this.
I'll look into the defines. Thanks!

@bill88t bill88t marked this pull request as draft August 5, 2024 20:27
@bill88t
Copy link
Contributor Author

bill88t commented Aug 5, 2024

Alright, the display is now rotated properly. This is ready to go.

@bill88t bill88t marked this pull request as ready for review August 5, 2024 21:17
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 1e9370a into adafruit:master Aug 5, 2024
123 checks passed
@bill88t bill88t deleted the tws3 branch August 5, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants