Fix for options handling #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, i'll publish a new npm version after the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoffeeScript modifies the options object that is passed in. Subsequent compile calls with the same options hash result in the closure wrapper and various helper functions being stripped from the source. This is a good idea when concatenating several files together, but for one-off files (the more likely use case for this package), it introduces all kinds of errors.
This patch clones the options object each time so the original options hash is not polluted by the CoffeeScript compiler.
This is the same problem encountered in this pull request for grunt-coffee: avalade/grunt-coffee#8