Patch to fix coffeescript's modifying the options object. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler adds attributes to the options object on the first pass; consequential passes are not decorated with the '__extend()' and other functions. This makes sense when compiling a long list of javascript files into a single file, but grunt-coffee compiles each file into its javascript equivalent at the target end. This patch gives a fresh clone of the options object passed from the user's grunt.js configuration file to each call to coffee.compile().
|
Thanks for the contribution and the catch! |
avalade
added a commit
that referenced
this pull request
Jul 24, 2012
Patch to fix coffeescript's modifying the options object.
|
Would you mind pushing this to npm? |
|
Should be out there in version 0.4 |
|
in version 0.0.4, that is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler adds attributes to the options object on the first pass; follow-on passes are not decorated with the '__extend()' and other functions coffeescript adds to the top of each generated javascript file. This makes sense when compiling a long list of javascript files into a single file, but grunt-coffee compiles each file into its javascript equivalent at the target end.
This patch gives a fresh clone of the options object passed from the user's grunt.js configuration file to each call to coffee.compile(), thus eliminating this problem.