ts: add buffer as allowed type for input, fix #248

adaltas · Aug 9, 2019 · fecf171 · fecf171
1 parent 9c53199
commit fecf171
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@
 * max_comment_size: new option
 * promise: new API module
 
+## Trunk
+
+* ts: add buffer as allowed type for input, fix #248
+
 ## Version 4.4.4
 
 * package: latest dependencies

diff --git a/test/api.types.ts b/test/api.types.ts
@@ -7,6 +7,22 @@ describe('API Types', () => {
 
   describe('Parser', () => {
 
+    it('Respect parse signature', () =>{
+      // No argument
+      parse()
+      parse("")
+      parse("", () => {})
+      parse("", {})
+      parse("", {}, () => {})
+      parse(Buffer.from(""))
+      parse(Buffer.from(""), () => {})
+      parse(Buffer.from(""), {})
+      parse(Buffer.from(""), {}, () => {})
+      parse(() => {})
+      parse({})
+      parse({}, () => {})
+    })
+
     it('Expose options', () => {
       const parser: Parser = parse()
       const options: Options = parser.options
@@ -107,6 +123,7 @@ describe('API Types', () => {
         return fields
       }
       options.columns = (record: string[]) => {
+        record
         return ['string', undefined, null, false, {name: 'column-name'}]
       }
     })