Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Memory leak] Spnego tokens aren't properly freed in gss_bind.cc #31

Closed
gboutry opened this issue Sep 13, 2021 · 1 comment
Closed

[Memory leak] Spnego tokens aren't properly freed in gss_bind.cc #31

gboutry opened this issue Sep 13, 2021 · 1 comment

Comments

@gboutry
Copy link
Contributor

gboutry commented Sep 13, 2021

Spnego tokens aren't properly freed. They are buffer attributes, therefore they're not deleted when class destructor is called.

We could use this opportunity to return an ArrayBuffer to node (with proper lifetime) and let the node side encode to b64, therefore removing the need for the files base64.h and base64.cc
@gboutry gboutry mentioned this issue Sep 13, 2021
Closed
gboutry added a commit that referenced this issue Sep 14, 2021
@gboutry
feat: Refactor generate_spnego_token
d7e8d8c 
Now the generate_spnego_token returns a NAPI buffer (extends UINT8ARRAY from js).
The conversion to base64 is performed in the node js side.

Refs: #21, #31
@gboutry gboutry mentioned this issue Sep 14, 2021
Merged
gboutry added a commit that referenced this issue Sep 14, 2021
@gboutry
feat: Refactor generate_spnego_token
f357927 
Now the generate_spnego_token returns a NAPI buffer (extends UINT8ARRAY from js).
The conversion to base64 is performed in the node js side.

Refs: #21, #31
gboutry added a commit that referenced this issue Sep 14, 2021
@gboutry
feat: Refactor generate_spnego_token
5294d63 
Now the generate_spnego_token returns a NAPI buffer (extends UINT8ARRAY from js).
The conversion to base64 is performed in the node js side.

Refs: #21, #31
@gboutry
Copy link
Contributor Author

gboutry commented Sep 14, 2021

Closing this issue, solved by #32

@gboutry gboutry closed this as completed Sep 14, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gboutry