Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message when no assets found #261

Merged
merged 5 commits into from
Dec 18, 2021
Merged

Add message when no assets found #261

merged 5 commits into from
Dec 18, 2021

Conversation

cherry-john
Copy link
Contributor

Closes #259

Version:

V2

Checklist:

  • Updates documentation (if so - is it in this PR, or on the v2 branch?)
  • Tested locally

@cherry-john cherry-john added the bug Something isn't working label Dec 16, 2021
@cherry-john cherry-john requested review from Jbithell and a team December 16, 2021 21:19
@cherry-john cherry-john self-assigned this Dec 16, 2021
@netlify
Copy link

netlify bot commented Dec 16, 2021

❌ Deploy Preview for adamrms-app failed.

🔨 Explore the source changes: f5a17c5

🔍 Inspect the deploy log: https://app.netlify.com/sites/adamrms-app/deploys/61be1d12d2d4730007ad2855

@netlify
Copy link

netlify bot commented Dec 16, 2021

✔️ Deploy Preview for adamrms-docs canceled.

🔨 Explore the source changes: f5a17c5

🔍 Inspect the deploy log: https://app.netlify.com/sites/adamrms-docs/deploys/61be1d125b96ce0008bf6121

@Jbithell Jbithell had a problem deploying to adamrms-v2-staging-pr-261 December 18, 2021 17:08 Failure
@Jbithell Jbithell had a problem deploying to adamrms-v2-staging-pr-261 December 18, 2021 17:23 Failure
@Jbithell Jbithell had a problem deploying to adamrms-v2-staging-pr-261 December 18, 2021 17:36 Failure
@Jbithell Jbithell temporarily deployed to adamrms-v2-staging-pr-261 December 18, 2021 17:40 Inactive
@Jbithell Jbithell merged commit 8bde02a into v2 Dec 18, 2021
@Jbithell Jbithell deleted the 259-v2-asset-api-crash branch December 18, 2021 17:45
cherry-john added a commit that referenced this pull request Dec 27, 2021
commit f199370
Author: James Bithell <Jbithell@users.noreply.github.com>
Date:   Sat Dec 18 18:17:06 2021 +0000

    Lint Everything (#268)

    * Lint App

    * Don't lint on Netifly

    * Apply requested tsconfig changes

commit 8bde02a
Author: John Cherry <jac677@york.ac.uk>
Date:   Sat Dec 18 17:45:29 2021 +0000

    Add message when no assets found (#261)

    * Add message when no assets found

    * Allow assets to be accessed directly

    * Fix merge conflict

    * Remove Import

    Co-authored-by: James Bithell <Jbithell@users.noreply.github.com>
    Co-authored-by: Robert Watts <11817698+Robert-Watts@users.noreply.github.com>
    Co-authored-by: Robert Watts <mail@rlwatts.co.uk>
cherry-john pushed a commit that referenced this pull request Dec 28, 2021
* add project list + fix Font awesome

* add more content to projects

* Fix date Data

* Lint to ease merge

* Squashed commit of the following:

commit f199370
Author: James Bithell <Jbithell@users.noreply.github.com>
Date:   Sat Dec 18 18:17:06 2021 +0000

    Lint Everything (#268)

    * Lint App

    * Don't lint on Netifly

    * Apply requested tsconfig changes

commit 8bde02a
Author: John Cherry <jac677@york.ac.uk>
Date:   Sat Dec 18 17:45:29 2021 +0000

    Add message when no assets found (#261)

    * Add message when no assets found

    * Allow assets to be accessed directly

    * Fix merge conflict

    * Remove Import

    Co-authored-by: James Bithell <Jbithell@users.noreply.github.com>
    Co-authored-by: Robert Watts <11817698+Robert-Watts@users.noreply.github.com>
    Co-authored-by: Robert Watts <mail@rlwatts.co.uk>

* close #264

Also fixes Linting issues

* Add Project Assets view

Currently just a list, needs statuses to be added

* Add crew list

TODO: add popovers when project is updated to Ionic 6

* Update type.d.ts

* resolve comments

Co-authored-by: James Bithell <Jbithell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle a failed api response without crashing
3 participants