Lint Everything #268
Merged
Lint Everything #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for adamrms-app ready! 🔨 Explore the source changes: 8540323 🔍 Inspect the deploy log: https://app.netlify.com/sites/adamrms-app/deploys/61be252f05cde80007fab8e8 😎 Browse the preview: https://deploy-preview-268--adamrms-app.netlify.app/ |
|
✔️ Deploy Preview for adamrms-docs canceled. 🔨 Explore the source changes: 8540323 🔍 Inspect the deploy log: https://app.netlify.com/sites/adamrms-docs/deploys/61be252f05cde80007fab8ea |
Robert-Watts
previously approved these changes
Dec 18, 2021
cherry-john
added a commit
that referenced
this pull request
Dec 27, 2021
commit f199370 Author: James Bithell <Jbithell@users.noreply.github.com> Date: Sat Dec 18 18:17:06 2021 +0000 Lint Everything (#268) * Lint App * Don't lint on Netifly * Apply requested tsconfig changes commit 8bde02a Author: John Cherry <jac677@york.ac.uk> Date: Sat Dec 18 17:45:29 2021 +0000 Add message when no assets found (#261) * Add message when no assets found * Allow assets to be accessed directly * Fix merge conflict * Remove Import Co-authored-by: James Bithell <Jbithell@users.noreply.github.com> Co-authored-by: Robert Watts <11817698+Robert-Watts@users.noreply.github.com> Co-authored-by: Robert Watts <mail@rlwatts.co.uk>
cherry-john
pushed a commit
that referenced
this pull request
Dec 28, 2021
* add project list + fix Font awesome * add more content to projects * Fix date Data * Lint to ease merge * Squashed commit of the following: commit f199370 Author: James Bithell <Jbithell@users.noreply.github.com> Date: Sat Dec 18 18:17:06 2021 +0000 Lint Everything (#268) * Lint App * Don't lint on Netifly * Apply requested tsconfig changes commit 8bde02a Author: John Cherry <jac677@york.ac.uk> Date: Sat Dec 18 17:45:29 2021 +0000 Add message when no assets found (#261) * Add message when no assets found * Allow assets to be accessed directly * Fix merge conflict * Remove Import Co-authored-by: James Bithell <Jbithell@users.noreply.github.com> Co-authored-by: Robert Watts <11817698+Robert-Watts@users.noreply.github.com> Co-authored-by: Robert Watts <mail@rlwatts.co.uk> * close #264 Also fixes Linting issues * Add Project Assets view Currently just a list, needs statuses to be added * Add crew list TODO: add popovers when project is updated to Ionic 6 * Update type.d.ts * resolve comments Co-authored-by: James Bithell <Jbithell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.