Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in cmder #26

Closed
viceice opened this issue Feb 10, 2020 · 21 comments
Closed

Not working in cmder #26

viceice opened this issue Feb 10, 2020 · 21 comments

Comments

@viceice
Copy link

viceice commented Feb 10, 2020

Env
win: 10 1909 18363.592
pwsh: 6.2.4
posh-git: 1.0.0-beta3
oh-my-posh: 2.0.381 (Theme Paradox)
font: Delugia-Nerd-Font (installed with scoop)

Windows Terminal
image

Cmder
image

@Finii
Copy link
Collaborator

Finii commented Feb 10, 2020

What font are you using?
What is the expected behavior, in contrast to the displayed screenshots?

I guess you could mean the 'four horizontal bars' thing (called 'strictly equivalent') is shown with Winterm and not with Cmder.
If this is the case, please see issue #22, which is exactly about this.

@viceice
Copy link
Author

viceice commented Feb 10, 2020

I used Delugia-Nerd-Font (installed with scoop).

powershell
image

Using Hack-NF works
cmder
image
powershell
image

Maybe #22 is related.

@Finii
Copy link
Collaborator

Finii commented Feb 10, 2020

Oh sorry, you specified the used font in the original post. blush

Maybe the description in #22 is not easily understood.

  • Nerd Fonts (even 'full') has no strictly-equivalent-glyph.
  • Font rendering in Windows seems to be hard, some applications substitude missing glyphs by other fonts (as the font rendering should automatically), but some don't. As I usually only work on Non-Windows systems I have no specifics for the reason of that fail.

So if this is about the missing 'strictly equivalent', then sorry this can not be fixed here, because:

  • Cascadia Code does not provide it
  • Nerd Fonts --complete does not provide it

Anyhow, as workaround you could use the patched Cascadia Code version from Nerd Fonts: Caskaydia Cove. They must use some other additional source fonts. I did not dive into the relevant PR there.

As there is now a 'official' Nerd Fonts patched version this repository became kind of obsolete.
Note that even Microsofts Powerline version of Cascadia does not include the missing glyph.

@Finii
Copy link
Collaborator

Finii commented Feb 10, 2020

Forgot to mention: Caskaydia Cove Complete does include a full set of math symbols, including the strictly-equivalent.

@viceice
Copy link
Author

viceice commented Feb 10, 2020

ok thanks

@viceice
Copy link
Author

viceice commented Feb 10, 2020

CascaydiaCove NF not working either

WinTerm
image

Cmder
image

@Finii
Copy link
Collaborator

Finii commented Feb 10, 2020

You are right. Again sorry, I checked Cascaydia Cove in fontforge, but it has NO math symbols at all, and I misread the placeholder images for the actual glyphs:

image

They somehow removed glyphs from the original set?!

So this boils down to the first statement:
This is a defect/quirk of the Windows font rendering mechanism. If a glyph is not existing in the used font it should try a substitute. Obviously this works with some Windows applications (WinTerm), but not with other (Powershell).

Anyhow, as workaround you could use the patched Cascadia Code version from Nerd Fonts: Caskaydia Cove. They must use some other additional source fonts.

Well that statement was wrong. They have no additional source fonts, and thus they do not provide the glyph in question. In fact Caskaydia is worse than Delugia, as it drops glyphs of the original Cascadia font.

@Finii
Copy link
Collaborator

Finii commented Feb 10, 2020

As you mentioned hack. That font (unpatched, original) has the full math glyphs:

image

As this one glyph here seems in high demand, I will check if we can patch it over from hack to Delugia, hold on...

@viceice
Copy link
Author

viceice commented Feb 10, 2020

Until then i use Hack NF as a workaround

@Finii
Copy link
Collaborator

Finii commented Feb 10, 2020

Please check the font with glyphs added from the CI output:
https://github.com/adam7/delugia-code/pull/28/checks?check_run_id=436241838
It's in the top right, 'artifacts'.

Direct link: https://github.com/adam7/delugia-code/suites/448451606/artifacts/1716969

If possible please also check in a non-monospace application like Visual Code with ligatures enabled, or Writer or something. Thank you.

Sometimes Windows is hard to convince a font changed. Possibly it is best to first uninstall the old Delugia and then install the new font. I never had problems with just installing over another, but other have reported issues in the past.

@viceice
Copy link
Author

viceice commented Feb 10, 2020

Using the Delugia Nerd Font Powerline variant works now in powershell and wintem
image

and cmder
image

vscode
image

@Finii
Copy link
Collaborator

Finii commented Feb 10, 2020

@torpederos Maybe you want to try out PR #28 (see instructions above) as solution for your issue #22.

@viceice
Copy link
Author

viceice commented Feb 12, 2020

looks like someon has found the how to add fallback fonts

image

ryanoasis/nerd-fonts#375 (comment)

@Finii
Copy link
Collaborator

Finii commented Feb 12, 2020

Great! Thank you for finding that information.

But I would still include not identical to and strictly equivalent to from Hack.ttf.
We already have the neighboring identical to and so on, for me it does not make sense to not-include these often used chars. See commit message of #28.

What do you think? I would generate a Delugia release then.

@viceice
Copy link
Author

viceice commented Feb 12, 2020

I would include them too, but may we can add fallback fonts registry key for missing glyphs?

@viceice
Copy link
Author

viceice commented Feb 12, 2020

@Finii Question out of scope: Can we add a statement to the readme for what the differences between normal and complete font are?

@Finii
Copy link
Collaborator

Finii commented Feb 12, 2020

I'm not sure if a font can set a registry key.

I reckon the applications that work use the Uniscribe engine (and thus font fallback), while the others use GDI (and need the font linking registry key).

This is unfortunately not a region of my expertise.
Maybe Ryan comes up with something.

I close this now, as the original problem is solved with the new release.
Thanks for the feedback, Fini

@Finii Finii closed this as completed Feb 12, 2020
@Finii
Copy link
Collaborator

Finii commented Feb 12, 2020

Ah, about the readme: Feel free to add a pull request ;-D

I can add a link to the relevant description on the Nerd Fonts page.

@Finii
Copy link
Collaborator

Finii commented Feb 12, 2020

Expanded README. Hope this is what you had in mind :-)

@viceice
Copy link
Author

viceice commented Feb 12, 2020

Thanks very much.

@Finii
Copy link
Collaborator

Finii commented Feb 13, 2020

Applications not showing fallback fonts on Windows really are problem of that Application and not of the font. Here is an example how the observed problem has been fixed by using Uniscribe instead of GDI:

mintty/mintty@d0eed42

One should raise issues at the respective application repositories (if available).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants