Feature/add more math glyphs #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] When Nerd Font evolves and new commits become pulled to master our scripts might break. See also warning at https://github.com/ryanoasis/nerd-fonts#unstable-file-paths This is the case here, because Nerd Fonts decided to rename Cascadia when it patches it. Our subsequent renaming then failes. [how] Reference release v2.1.0 as this is master at the moment. Adapt to output new file name. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] Using powerline with git sometimes needs the glyphs - 0u2262 not identical to - 0u2263 strictly equivalent to Usually they are provided by other installed fonts and the system's font rendering mechanism should handle that. But that does not work on some Windows applications that work as shells like PowerShell and Cmdr [how] Grab these glyphs from a differnt font and patch it into our destination font. Nerd Fonts does not patch these into fonts, usually. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Closed
adam7
approved these changes
Feb 11, 2020
|
Addressed nerd-fonts version in PR #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These glyphs have been asked for by issue #22 and #26. People using powerline and git usually have them in the default config, but that breaks in some Windows shells.
This is not as thoroughly tested on all platforms as I would wish, unfortunately.
[why]
Using powerline with git sometimes needs the glyphs
Usually they are provided by other installed fonts and the system's font
rendering mechanism should handle that. But that does not work on some
Windows applications that work as shells like
PowerShellandCmdr[how]
Grab these glyphs from a differnt font (i.e. Hack) which is included in Nerd Fonts' repo and patch it into our destination font. Nerd Fonts does not patch these into fonts, usually.
[note]
This PR depends (in fact includes) PR #27. I can not properly separate them because because of github limitations, sorry (or I'm too dump).