Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored APIClient #51

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Refactored APIClient #51

merged 1 commit into from
Jul 4, 2022

Conversation

adamayoung
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #51 (a4cc6de) into main (6f6cbf1) will increase coverage by 2.91%.
The diff coverage is 67.39%.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   95.27%   98.19%   +2.91%     
==========================================
  Files          77       78       +1     
  Lines         868      885      +17     
==========================================
+ Hits          827      869      +42     
+ Misses         41       16      -25     
Impacted Files Coverage Δ
Sources/TMDb/Client/APIClient.swift 100.00% <ø> (ø)
Sources/TMDb/TMDbAPI.swift 40.00% <6.25%> (-60.00%) ⬇️
Sources/TMDb/Client/Serialiser.swift 100.00% <100.00%> (ø)
Sources/TMDb/Client/TMDbAPIClient.swift 97.67% <100.00%> (+83.09%) ⬆️
...ices/Certifications/TMDbCertificationService.swift 100.00% <100.00%> (ø)
...vices/Configuration/TMDbConfigurationService.swift 100.00% <100.00%> (ø)
...s/TMDb/Services/Discover/TMDbDiscoverService.swift 100.00% <100.00%> (ø)
...ources/TMDb/Services/Movies/TMDbMovieService.swift 100.00% <100.00%> (ø)
...urces/TMDb/Services/People/TMDbPersonService.swift 100.00% <100.00%> (ø)
...urces/TMDb/Services/Search/TMDbSearchService.swift 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f6cbf1...a4cc6de. Read the comment docs.

@adamayoung adamayoung merged commit 8b97f90 into main Jul 4, 2022
@adamayoung adamayoung deleted the refactor/api-client branch July 4, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant