[scala/en] Minor improvements #4671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffliu
requested changes
Aug 25, 2023
Comment on lines
+686
to
+691
| // functional languages. It is so often used that it gets its own shorthand. | ||
| // This function takes `f` and `l` and automatically fills in `K` and `V`. | ||
| def mapList[K,V](f: K=>V, l: List[K]): List[V] = l match { | ||
| case Nil => Nil | ||
| case h :: t => f(h) :: mapList(f, t) | ||
| } |
There was a problem hiding this comment.
This is not the point of this section. The mapList example here demostrates generic type inference, not implicit type classes.
|
|
||
| // Certain collections (such as List) in Scala have a `foreach` method, | ||
| // which takes as an argument a type returning Unit - that is, a void method | ||
| // Some languages call this the `iter` method |
There was a problem hiding this comment.
foreach functions are common enough that I don't think you need iter to illustrate. Most modern languages use forEach anyway. Please remove this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[language/lang-code](example[python/fr-fr]or[java/en])