Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MITM proxying to hosts whose names begin with "http" is broken #92

Closed
oxtoacart opened this issue Sep 24, 2013 · 3 comments
Closed

MITM proxying to hosts whose names begin with "http" is broken #92

oxtoacart opened this issue Sep 24, 2013 · 3 comments
Milestone

Comments

@oxtoacart
Copy link
Collaborator

This was discovered by @robfletcher who tried using MITM to proxy requests to https://httpbin.org/get.

This was getting parsed into the empty string "", causing us to fall back on the host header to identify the host. Unfortunately, at that point, we have lost the port information and consequently end up defaulting to port 80, which won't work for this SSL connection.

@robfletcher
Copy link

Ha! Is that what it is. I can't imagine what you had to go through to figure that out.

@oxtoacart
Copy link
Collaborator Author

@robfletcher yeah, you don't want to know ;)

@oxtoacart
Copy link
Collaborator Author

Okay, I fixed the parsing. While I was at it, I added the ability to launch the proxy in MITM mode.

MediumOne pushed a commit to MediumOne/LittleProxy that referenced this issue Jun 7, 2022
…logging.log4j-log4j-core-2.17.0

Bump log4j-core from 2.16.0 to 2.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants