New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): 🐛 fixed the issue with foldLine not correctly handling strings containing emojis. #258

Merged

adamgibbons merged 2 commits into adamgibbons:master from haydenull:master

Dec 14, 2023

Contributor

haydenull commented Nov 22, 2023

fixed the issue with foldLine not correctly handling strings containing emojis.

The native js does not pay attention to surrogate pairs.

'🍅'.length // => 2
'🍅a'.slice(1) // => �a

closed #257

haydenull and others added 2 commits

November 22, 2023 14:31


          fix(utils): 🐛 fixed the issue with foldLine not correctly handling st…

c7a497d

…rings containing emojis.

closed adamgibbons#257


          Merge branch 'master' into master

87f118f

adamgibbons merged commit 6e07e40 into adamgibbons:master

renovate bot added a commit to inabagumi/shinju-date that referenced this pull request


          build(deps): update dependency ics to ^3.7.1 (#3755)

4b82ad9

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ics](https://togithub.com/adamgibbons/ics) | [`^3.6.2` ->
`^3.7.1`](https://renovatebot.com/diffs/npm/ics/3.6.2/3.7.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/ics/3.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ics/3.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ics/3.6.2/3.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ics/3.6.2/3.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>adamgibbons/ics (ics)</summary>

###
[`v3.7.1`](https://togithub.com/adamgibbons/ics/compare/v3.7.0...ecc8cf54f84da92b3a0fe0fa049fc65cda4d1451)

[Compare
Source](https://togithub.com/adamgibbons/ics/compare/v3.7.0...ecc8cf54f84da92b3a0fe0fa049fc65cda4d1451)

### [`v3.7.0`](https://togithub.com/adamgibbons/ics/releases/tag/v3.7.0)

[Compare
Source](https://togithub.com/adamgibbons/ics/compare/v3.6.3...v3.7.0)

#### What's Changed

- fix(utils): 🐛 fixed the issue with foldLine not correctly handling
strings containing emojis. by
[@&#8203;haydenull](https://togithub.com/haydenull) in
[adamgibbons/ics#258

#### New Contributors

- [@&#8203;haydenull](https://togithub.com/haydenull) made their first
contribution in
[adamgibbons/ics#258

**Full Changelog**:
adamgibbons/ics@v3.6.3...v3.7.0

### [`v3.6.3`](https://togithub.com/adamgibbons/ics/releases/tag/v3.6.3)

[Compare
Source](https://togithub.com/adamgibbons/ics/compare/v3.6.2...v3.6.3)

#### What's Changed

- Allow `organiser` to contain comma, ensure that new lines in values
don't break output, and various other tweaks (take 2) by
[@&#8203;tjenkinson](https://togithub.com/tjenkinson) in
[adamgibbons/ics#261
- Fix exception date-time test by
[@&#8203;tjenkinson](https://togithub.com/tjenkinson) in
[adamgibbons/ics#262

**Full Changelog**:
adamgibbons/ics@v3.6.2...v3.6.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/inabagumi/shinju-date).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment