Skip to content

Commit

Permalink
tests should not pass - beets is not totally reset after teardown
Browse files Browse the repository at this point in the history
  • Loading branch information
jackisback committed Mar 19, 2020
1 parent fa852ac commit 18b958f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
'requests'
],

# Extras needed during testing
extras_require={
'tests': ['requests'],
},
Expand Down
4 changes: 3 additions & 1 deletion test/functional/000_basic_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ def test_plugin_shortname_no_arguments(self):
self.assertIn("Usage: beet goingrunning [training] [options] [QUERY...]", stdout)

def test_with_core_plugin_acousticbrainz(self):
"""Introduced after release 1.1.1 when discovered core bug failing to compare flexible field types
"""Flexible field type declaration conflict
Introduced after release 1.1.1 when discovered core bug failing to compare flexible field types
Ref.: https://beets.readthedocs.io/en/stable/dev/plugins.html#flexible-field-types
This bug is present in beets version 1.4.9 so until the `item_types` declaration in the `GoingRunningPlugin`
class is commented out this test will pass.
Expand All @@ -50,3 +51,4 @@ class is commented out this test will pass.
line = get_single_line_from_output(stdout, prefix)
expected = "{0} {1}".format(prefix, ", ".join([extra_plugin, PLUGIN_NAME]))
self.assertEqual(expected, line)
self.tearDown()
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ commands =
[testenv:flake8]
deps =
flake8
commands = flake8 beetsplug test setup.py
commands = flake8 beetsplug test setup.py

0 comments on commit 18b958f

Please sign in to comment.