Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ON" text below themesFunctions Script in firefox displaying in Firefox #55

Closed
brianbroken opened this issue Oct 17, 2012 · 9 comments
Closed

Comments

@brianbroken
Copy link

In firefox 16.0.1 I am getting the text "on" just after the themesFunctions Script when viewed in the Source. Can you tell me why this is displaying here? It does not appear in any other browser. Am I missing something simple? Thank you.

<script id="rootDir" type="text/javascript">
<script>
<script id="themeFunctions">
on
<script id="console" type="text/javascript">
<script class="extras" type="text/javascript">

@las3r
Copy link

las3r commented Oct 17, 2012

I can verify this, it only does this in firefox (tested under Windows 7 x64), chrome and IE9 are not affected.

@adamjgrant
Copy link
Owner

Thanks folks. Fixed this a few days ago and it will go out with 1.2.0

However, if you want the fix now, you can just download kickstrap.js and kickstrap.min.js from the canary branch:

https://github.com/ajkochanowicz/Kickstrap/tree/canary/Kickstrap/js

If you're using the CDN-hosted version, I'm about to update that as well so you should see that "on" thing go away.

@adamjgrant
Copy link
Owner

Before I close this ticket, could someone just verify that this works okay? Thanks.

@las3r
Copy link

las3r commented Oct 17, 2012

I just tried it (canary branch), and it solves the issue.

Thanks for the super-quick reply, and thanks even more for Kickstrap!

Erik

@adamjgrant
Copy link
Owner

I'm actually getting a few errors from this. "opts" is not defined. I'm going to work on a fix now in case this shows up for you. I should officially advise everyone to stick with the old version of kickstrap.js for now until I've thoroughly tested the one for 1.2

That being said, if you live on the edge, just keep checking back on the canary branch.

@las3r
Copy link

las3r commented Oct 17, 2012

I'm just doing some other tests, and Indeed just hit the "opts not defined" error in my console. I'll light a campfire for the night to wait on the fix... 👍 haha

@adamjgrant
Copy link
Owner

Try the new (new) one in canary now.

By the way, just so you know, Kickstrap will think you're running 1.2.0 so if you get a message with the updater app that says "upgrade to 1.1.0" that's why. (You don't need to upgrade)

Adam Kochanowicz
UX Designer
Debtdomain.com

Le mercredi, octobre 17, 2012 à 5:35 PM, erikhoeksma a écrit :

I'm just doing some other tests, and Indeed just hit the "opts not defined" error in my console. I'll light a campfire for the night to wait on the fix... haha


Reply to this email directly or view it on GitHub (#55 (comment)).

@las3r
Copy link

las3r commented Oct 17, 2012

I already saw that :-)! Thank you very much for the quick fixes. Livin' on the edge!

<3 Kickstrap

@brianbroken
Copy link
Author

Thank you so much, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants