Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests #27

Closed
wants to merge 4 commits into from
Closed

Pull Requests #27

wants to merge 4 commits into from

Conversation

nickl-
Copy link

@nickl- nickl- commented Apr 29, 2012

Apologies I am still stuck in the stone age looking for where I am suppose to submit my patches and now I hear we are to do pull requests. Well here goes, please bare with me for the first few rounds while I stumble along. Please don't hesitate to tell mo what I am doing wrong, lets not let the tech waste unnecessary time.

  1. 7732729 is purely rearranging white space to reduce the differences reported when comparing with current h5bp. Only pertaining to index.html and sample_index.html. I will go ahead and do the update itself soon if you'd like.
  2. ea30d00 The jQuery update fixes to the .html files only. Since the new h5bp update refactors the lib folder I thought it best not to over complicate this fix now, it will at least allow users to use the google cdn.
  3. bef1683 Slate import variables.less fix. Which then turns it completely upside down. I did spend today getting slate to an acceptable state again taking time to include more variables with commonly used settings. You will be seeing a post about that soon.

Shout if something is unclear.

nico added 3 commits April 28, 2012 01:56
…p versions I noticed some blocks being falsely reported as changed. Following a path of least resistance I rearranged them back to their original locations. See issue 26 merging with boilerplate.
@adamjgrant
Copy link
Owner

Sorry, I just want to have a look over on this before I pull. Thanks for your patience. I'll have some more time later.

@nickl-
Copy link
Author

nickl- commented Apr 30, 2012

Updated commit range to also include h5bp merge see #26

@nickl-
Copy link
Author

nickl- commented May 9, 2012

Any progress on this?

@adamjgrant
Copy link
Owner

Hi, Sorry, Nickl. Please see my update here #16 (at the top)

@nickl-
Copy link
Author

nickl- commented May 11, 2012

Adam? You don't have to do this all on your own, you know? That's why it's open source, silly. =)

No one is expecting you to place these "charity" commitments above your bread and butter or whatever else might be happening, a sick grandma, new kittens, bad break up, tonsillitis, who knows it's happened to us all and you will be excused.

But it's not ok if the project has to suffer because you are not able to give it or the community the attention they deserve.

It is obvious I am not helping you where you want it so I am going to delete this repo soon to start over, if you want this grab it now. I will try another approach and see if that might work because you obviously need the help but as the saying goes, you can bring the donkey to the water but you can't make it drink.

@nickl-
Copy link
Author

nickl- commented May 11, 2012

You've been busy the last few days, glad to see! =)

Keep up the good work!

@nickl- nickl- closed this Jun 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants