-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of BoolConst #6
Conversation
I know I sort of made a big deal out of this last night, but I was thinking and I don't think we need to do this as long as we can justify the way we do it in the master branch. The justification that we have for what we have in the master branch is that by having the two ways represented slightly differently we can evaluate the following stuff the same way swi-prolog does it. ?- b(a(true)). With making them both the same thing, the evaluator would evaluate that to true. Also, it is going to be a pain to fix all the code and tests and I would rather focus on the report. |
Fixed all evaluator and all tests to remove boolconst. although since you made the pr request you should have fixed all the code, like i did for the previous pr request but its ok. |
When I run
It looks like this block is duplicated. Or should one of them be for |
fixed |
The purpose of this PR is to remove
BoolConst
from the AST. This allows for a uniform treatment of "true" and "false" in parsing and evaluating. The following expressions:should have the same representation in the AST now.