do not use quotes on perms in template config #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feature branch should have been more correctly named: feature/fix-template-perms. |
|
Nice catch! Looks like I need to update the test kitchen suite to make sure it's also testing setting perms. |
adamkrone
added a commit
that referenced
this pull request
Nov 18, 2015
do not use quotes on perms in template config
adamkrone
added a commit
that referenced
this pull request
Nov 19, 2015
Prior to PR #33, this was set as a string which caused consul-template to error out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes quotes on perms field in template configuration. Without this, consul-template fails to start correctly and gives this error:
'template[0].perms' expected type 'os.FileMode', got unconvertible type 'string'