Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use quotes on perms in template config #33

Merged
merged 1 commit into from Nov 18, 2015

Conversation

Projects
None yet
2 participants
@atongen
Copy link
Contributor

commented Nov 18, 2015

Removes quotes on perms field in template configuration. Without this, consul-template fails to start correctly and gives this error:

'template[0].perms' expected type 'os.FileMode', got unconvertible type 'string'

@atongen

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2015

Feature branch should have been more correctly named: feature/fix-template-perms.

@adamkrone

This comment has been minimized.

Copy link
Owner

commented Nov 18, 2015

Nice catch! Looks like I need to update the test kitchen suite to make sure it's also testing setting perms.

adamkrone added a commit that referenced this pull request Nov 18, 2015

Merge pull request #33 from atongen/feature/fix-template-port
do not use quotes on perms in template config

@adamkrone adamkrone merged commit 51b5caf into adamkrone:master Nov 18, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

adamkrone added a commit that referenced this pull request Nov 19, 2015

Test setting perms
Prior to PR #33, this was set as a string which caused consul-template
to error out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.