Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 1 vulnerabilities #262

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

adamlaska
Copy link
Owner

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • packages/instant/package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 658/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS)
SNYK-JS-SEMVER-3247795
Yes Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: @0x/asset-swapper The new version differs by 250 commits.

See the full diff

Package name: @0x/subproviders The new version differs by 53 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

@google-cla
Copy link

google-cla bot commented Jun 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Native code @0x/fast-abi 0.0.5 packages/instant/package.json via @0x/asset-swapper@16.66.4
Install scripts @0x/fast-abi 0.0.5
  • Install script: install
  • Source: node-pre-gyp install --fallback-to-build=false || yarn build:rs:release
packages/instant/package.json via @0x/asset-swapper@16.66.4
Native code usb 1.9.2 packages/instant/package.json via @0x/asset-swapper@16.66.4
Install scripts msw 0.44.2
  • Install script: postinstall
  • Source: node -e "try{require('./config/scripts/postinstall')}catch(e){}"
packages/instant/package.json via @0x/asset-swapper@16.66.4
Network access msw 0.44.2 packages/instant/package.json via @0x/asset-swapper@16.66.4
Install scripts @0x/neon-router 0.3.5
  • Install script: install
  • Source: node-pre-gyp install --fallback-to-build
packages/instant/package.json via @0x/asset-swapper@16.66.4
Network access https-proxy-agent 5.0.1 packages/instant/package.json via @0x/asset-swapper@16.66.4
Network access ethers 5.7.2 packages/instant/package.json via @0x/assert@3.0.36, @0x/asset-swapper@16.66.4, @0x/subproviders@8.0.1, @0x/utils@5.6.4, @0x/web3-wrapper@7.6.5
Network access graphql-request 3.7.0 packages/instant/package.json via @0x/asset-swapper@16.66.4
Network access @mswjs/interceptors 0.17.9 packages/instant/package.json via @0x/asset-swapper@16.66.4
Network access express 4.18.2 packages/instant/package.json via @0x/asset-swapper@16.66.4

Next steps

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @0x/fast-abi@0.0.5
  • @SocketSecurity ignore msw@0.44.2
  • @SocketSecurity ignore @0x/neon-router@0.3.5
  • @SocketSecurity ignore usb@1.9.2
  • @SocketSecurity ignore https-proxy-agent@5.0.1
  • @SocketSecurity ignore ethers@5.7.2
  • @SocketSecurity ignore graphql-request@3.7.0
  • @SocketSecurity ignore @mswjs/interceptors@0.17.9
  • @SocketSecurity ignore express@4.18.2

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
@0x/asset-swapper 🆕 16.66.4 None +170 137 MB tobernguyen
typescript 🆕 3.9.10 None +0 54.1 MB typescript-bot

Footnotes

  1. https://docs.socket.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants