-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass CancellationToken To RunAsync and ReadAsync #230
Labels
enhancement
New feature or request
Milestone
Comments
khalidabuhakmeh
added a commit
to khalidabuhakmeh/simple-exec
that referenced
this issue
Oct 29, 2020
This allows folks to kill the running process using a CancellationTokenSource and its token (I think). Might need a set of eyeballs on this PR though. adamralph#230
khalidabuhakmeh
added a commit
to khalidabuhakmeh/simple-exec
that referenced
this issue
Oct 29, 2020
This allows folks to kill the running process using a CancellationTokenSource and its token (I think). Might need a set of eyeballs on this PR though. adamralph#230
adamralph
pushed a commit
to khalidabuhakmeh/simple-exec
that referenced
this issue
Oct 31, 2020
This allows folks to kill the running process using a CancellationTokenSource and its token (I think). Might need a set of eyeballs on this PR though. adamralph#230
Re-opening this, to consider whether |
Closed
Decided to support |
Released in 6.4.0-rc.1. @khalidabuhakmeh please give it a try. |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Use case(s)
Some processes are long-running tasks, and the ability to
kill
these processes might be a good thing. I have a process that starts playing an audio file and I'd like to stop the audio with a cancellationToken.Description
The issue is that the cancellation request needs to call
process.Kill
or else the process continues to run in the background.Alternatives
Handroll starting a process.
Additional context
I'll try and make an attempt myself at implementing the change, but my
async
foo is mediocre at best.The text was updated successfully, but these errors were encountered: