replace cmd.exe usage with optional params for windows

[adamralph]

cmd.exe is no longer used internally to execute commands on Windows.

There are two new optional parameters, windowsName and windowsArgs. If either the command name or arguments need to be different on Windows, they can be specified as arguments to these parameters. For example:

Run("foo", "bar", windowsName: "cmd.exe", windowsArgs: "/c foo bar");

[adamralph]

Released in alpha 1.

[adamralph]

@dtitenko @damianh @pawelros @leastprivilege please feel free to kick the tyres on this when you have time. Version is 6.0.0-alpha.1

[leastprivilege]

I tried it in IdentityModel

https://github.com/IdentityModel/IdentityModel/blob/features/simpleExecTests/build/build.csproj

works fine - both locally and on Azure Pipelines using the VS2017 image.

Once I switch to the VS2019 image - I get

https://dev.azure.com/netidentity/IdentityModel/_build/results?buildId=342

any idea?

[adamralph]

@leastprivilege no idea, but I got it to work by switching to build.cmd! IdentityModel/IdentityModel#218

I can only guess that something is borked with PowerShell on the new image.

[robertcoltheart]

Any chance this can be added to the readme? I spent ages looking for workarounds before I found this PR.

[adamralph]

@robertcoltheart is this what you had in mind? #185

[robertcoltheart]

Reviewed, thanks!