Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0.0 release #129

Closed
18 tasks done
adamralph opened this issue Jun 1, 2019 · 5 comments
Closed
18 tasks done

6.0.0 release #129

adamralph opened this issue Jun 1, 2019 · 5 comments
Milestone

Comments

@adamralph
Copy link
Owner Author

@pawelros regarding #119 (comment) - where are you doing this workaround? Is it in an OSS repo?

I ask because I'd be interested in switching it to SimpleExec 6.0.0-beta.1.

@pawelros
Copy link

No, unfortunately, it is in a private repo. I will switch to SimpleExec 6.0.0-beta.1 and let you know about the outcome.

@damianh
Copy link
Contributor

damianh commented Jun 20, 2019

@adamralph Checked on private repo here, works fine.

I'm still encapsulating it in a helper method:

private static void RunCmd(string name, string args = null, string workingDirectory = null, bool noEcho = false)
            => Run(name, args, workingDirectory, windowsName: "cmd.exe", windowsArgs: $"/C {name} {args}", noEcho: noEcho);

Not a big deal really.

@adamralph
Copy link
Owner Author

Yeah, if you want to use cmd for all your calls on Windows, then that's what you'll have to do.

@adamralph
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants