Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encoding in Command.Read() #278

Closed
wants to merge 2 commits into from

Conversation

rasmus-unity
Copy link
Contributor

What

Added encoding parameter to Command.Read() method

Why

We experienced when running git diff --patch on Windows, that UTF8 changes where not returned correctly, assuming since Encoding.Default on Windows doesn't support Unicode/UTF8

Tests

None, but verified all existing tests are still passing. Let me know if you think there should be tests for this

@adamralph
Copy link
Owner

adamralph commented Mar 13, 2021

@rasmus-unity thanks for raising this PR. This seems like a good addition to the API.

I need to tweak the implementation a bit, and add tests, but you haven't given me permission to push to your branch, so I'm going to close this and replace it with another PR. Your name will still appear as a co-author of the implementation commit.

@adamralph adamralph closed this Mar 13, 2021
@adamralph adamralph added the duplicate This issue or pull request already exists label Mar 13, 2021
@rasmus-unity
Copy link
Contributor Author

Thanks @adamralph, appreciated that you accepted the change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants