Support preferred encoding when reading commands #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adam Ralph <adam@adamralph.com>
adamralph
added
enhancement
|
@rasmus-unity I've released this in 7.0.0-alpha.2, if you want to give it a try |
|
Thanks @adamralph for the quick response. I've confirmed that encoding support works for our use case on both Windows and Mac |
This was referenced Mar 15, 2021
Merged
Merged
Merged
Merged
Bump SimpleExec from 6.4.0 to 7.0.0 in /src
mauroservienti/NServiceBus.Extensions.DispatchRetries#53
Merged
Merged
This was referenced Mar 15, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #278. Thanks to @rasmus-unity for raising that PR!
This is a breaking changes because it adds the new optional parameter to
ReadAsyncbefore theCancellationToken, keeping theCancellationTokenlast, as recommended.