This repository has been archived by the owner on Feb 26, 2018. It is now read-only.
Fix for default value hydration of InputGroups #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find, thanks! Any chance of adding a quick test for this? If not I'll pull it down and get it in when I have a second then get it merged right in. Thanks again! |
|
Done. Thanks for merging. |
adamwathan
added a commit
that referenced
this pull request
Jun 9, 2015
Fix for default value hydration of InputGroups
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new InputGroup element doesn't correctly hydrate from old input or bound models.
While other elements implement this functionality through the core Form package, the InputGroup element is specific to BootForms and cannot rely on this cascade. Therefore default value hydration for InputGroups needs to be implemented explicitly.