Skip to content

Commit

Permalink
[java] MissingOverrideRule exception when analyzing PMD under Java 9
Browse files Browse the repository at this point in the history
Fixes pmd#1074

Jaxen is now shaded into pmd-core, without org.w3c.dom.**
  • Loading branch information
adangel committed Jun 24, 2018
1 parent 85a2917 commit 1126c68
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 16 deletions.
2 changes: 2 additions & 0 deletions docs/pages/release_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ This is a minor release.
* [#1193](https://github.com/pmd/pmd/issues/1193): \[core] Designer doesn't start with run.sh
* ecmascript
* [#861](https://github.com/pmd/pmd/issues/861): \[ecmascript] InnaccurateNumericLiteral false positive with hex literals
* java
* [#1074](https://github.com/pmd/pmd/issues/1074): \[java] MissingOverrideRule exception when analyzing PMD under Java 9
* java-bestpractices
* [#651](https://github.com/pmd/pmd/issues/651): \[java] SwitchStmtsShouldHaveDefault should be aware of enum types
* [#869](https://github.com/pmd/pmd/issues/869): \[java] GuardLogStatement false positive on return statements and Math.log
Expand Down
28 changes: 28 additions & 0 deletions pmd-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,34 @@
<suppressionsLocation>pmd-core-checkstyle-suppressions.xml</suppressionsLocation>
</configuration>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<configuration>
<artifactSet>
<includes>jaxen:jaxen</includes>
</artifactSet>
<filters>
<filter>
<artifact>jaxen:jaxen</artifact>
<includes>
<include>org/jaxen/**</include>
</includes>
<excludes>
<exclude>org/w3c/dom/**</exclude>
</excludes>
</filter>
</filters>
</configuration>
<executions>
<execution>
<goals>
<goal>shade</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
<dependencies>
Expand Down
4 changes: 0 additions & 4 deletions pmd-java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,6 @@
</plugins>
</build>
<dependencies>
<dependency>
<groupId>jaxen</groupId>
<artifactId>jaxen</artifactId>
</dependency>
<dependency>
<groupId>net.java.dev.javacc</groupId>
<artifactId>javacc</artifactId>
Expand Down
4 changes: 0 additions & 4 deletions pmd-java8/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,6 @@
<version>${project.version}</version>
</dependency>

<dependency>
<groupId>jaxen</groupId>
<artifactId>jaxen</artifactId>
</dependency>
<dependency>
<groupId>net.sourceforge.pmd</groupId>
<artifactId>pmd-core</artifactId>
Expand Down
4 changes: 0 additions & 4 deletions pmd-plsql/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,6 @@
<groupId>net.sourceforge.saxon</groupId>
<artifactId>saxon</artifactId>
</dependency>
<dependency>
<groupId>jaxen</groupId>
<artifactId>jaxen</artifactId>
</dependency>

<dependency>
<groupId>junit</groupId>
Expand Down
4 changes: 0 additions & 4 deletions pmd-xml/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@
</plugins>
</build>
<dependencies>
<dependency>
<groupId>jaxen</groupId>
<artifactId>jaxen</artifactId>
</dependency>
<dependency>
<groupId>net.sourceforge.pmd</groupId>
<artifactId>pmd-core</artifactId>
Expand Down

0 comments on commit 1126c68

Please sign in to comment.