-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to start a game with controller charging throws error #314
Comments
Thanks for this! I'll test and fix this soon! |
I am making updates on my fork, how best do you like to collaborate on things like this? The updates I am making initially are:
|
Hey! Thanks for helping out! You can make a pull request and I'll test it before merging. |
I have really hefty update I've been making over the last 2 weeks to refactor all of the games to reuse code and just generally make everything more consistent, e.g. move to enums instead of magic numbers. I still have a couple games left to do (Tournament and Ninja Bomb) I'll create a PR so you can take a look. Let me know your thoughts. |
That sounds great! I'll take a look at it an let you know! |
hi @mchirlin I finished fixing a few of the bugs for Joustmania (PS3 controller pairing/pi 5 issues), and have started to look at the work you've done! we are removing controller: 00:06:f7:8f:fa:3c which seems to be the Mac address of the controller plugged in, and the game seems to start without issues, I can't seem to trigger the same issue on my end, I've tried with both PS3/PS4 controllers, one and two plugged in and charging. Is there a specific way that you plugged in a controller (to the pi itself/a different charging solution), or something else I might have missed, perhaps in the solution you worked on? Just curious and trying to understand the root cause of the issue. Thanks for putting in the time for this! |
There were a couple of issues that I resolved. All are referenced with FIX
in a comment.
It was a bit ago, but what I remember was:
1. if all moves were charging and you tried to start a game it would just
say over and over, Not enough moves.
2. Sometimes moves were both alive and charging at the same time and which
threw errors when starting a game, don't remember what I did exactly to
make it happen, but I have seem them connect by both usb and
bluetooth simultaneously.
…On Mon, Mar 4, 2024 at 12:39 AM Aaron Angert ***@***.***> wrote:
hi @mchirlin <https://github.com/mchirlin> I finished fixing a few of the
bugs for Joustmania (PS3 controller pairing/pi 5 issues), and have started
to look at the work you've done!
I've been trying to reproduce the same issue not being able to start the
game with a controller plugged in on the master branch. Currently I've
tried plugging in one directly to the pi, that controller light goes out,
then pressed the trigger button on all of the rest of the remaining
controllers, the game (FFA) seems to start, and it prints out in the
console:
we are removing controller: 00:06:f7:8f:fa:3c
we are removing controller: 00:06:f7:8f:fa:3c
which seems to be the Mac address of the controller plugged in, and the
game seems to start without issues, I can't seem to trigger the same issue
on my end. Is there a specific way that you plugged in a controller (to the
pi itself/a different charging solution), or something else I might have
missed?
Just curious and trying to understand the root cause of the issue. Thanks
for putting in the time for this!
—
Reply to this email directly, view it on GitHub
<#314 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOKVJJNGKVK3GJZRXQITI3YWQCI3AVCNFSM6AAAAABCJ3YMUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVG43TAMJRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Michael Chirlin, Appian Senior Architect
Appian Corporation | Level 9, 7950 Jones Branch Dr, McLean, VA 22102
240 888 3845 | ***@***.*** |
<https://twitter.com/appianenabled> |
--
This message and any attachments are
solely for the intended recipient. If you are not the intended recipient,
disclosure, copying, use, or distribution of the information included in
this message is prohibited -- please immediately and permanently delete
this message.
|
yeah I seem to have been able to replicate the issue, |
Fixed from #317 |
Below is the error. Seems to be due to self.out_moves not being aligned with self.moves. Following line errors:
game_moves = [move.get_serial() for move in self.moves if self.out_moves[move.get_serial()] == Alive.on.value and (self.move_opts[move.get_serial()])[Opts.random_start.value] == Alive.off.value ]
Traceback (most recent call last):
File "/home/pi/JoustMania/piparty.py", line 1086, in
InitAudio()
File "/home/pi/JoustMania/piparty.py", line 662, in game_loop
self.check_start_game()
File "/home/pi/JoustMania/piparty.py", line 917, in check_start_game
self.start_game(random_mode=True)
File "/home/pi/JoustMania/piparty.py", line 962, in start_game
#start with only controllers that have pushed trigger
File "/home/pi/JoustMania/piparty.py", line 962, in
#start with only controllers that have pushed trigger
KeyError: 'a0:ab:51:35:da:42'
The text was updated successfully, but these errors were encountered: