Lightning example #1344
Merged
Lightning example #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
requested changes
Jul 29, 2022
There was a problem hiding this comment.
Thanks for the PR @edogab33 ! Changes look good, could you please also update the flwr version in pyproject.toml to flwr = "^1.0.0"?
There you go @danieljanes! |
danieljanes
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#1343
What does this implement/fix? Explain your changes.
Flower 1.0.0 requires config in
get_parameters(), keyword arguments instart_numpy_client()and the objectServerConfig()instart_server(). This fix updates quickstart_pytorch_lightning.py to run with the new version.Any other comments?
I tested it and it's working now.