Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Poetry 1.3.2 #1549

Merged
merged 7 commits into from
Jan 10, 2023
Merged

Upgrade to Poetry 1.3.2 #1549

merged 7 commits into from
Jan 10, 2023

Conversation

charlesbvll
Copy link
Member

Reference Issues/PRs

#1547

What does this implement/fix? Explain your changes.

Upgrading to Poetry 1.3.1, which also allows us to upgrade Ray to 2.2.0.

Any other comments?

None

@charlesbvll charlesbvll marked this pull request as draft January 9, 2023 19:46
@charlesbvll charlesbvll marked this pull request as ready for review January 9, 2023 20:02
@charlesbvll charlesbvll changed the title Upgrade to Poetry 1.3.1 and Ray 2.2.0 Upgrade to Poetry 1.3.1 Jan 9, 2023
danieljanes
danieljanes requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably update all instances of [build-system] according to these docs: https://python-poetry.org/docs/master/pyproject/#poetry-and-pep-517

@charlesbvll
Copy link
Member Author

@danieljanes I will probably open another PR afterwards for the Ray issue, it might be solved by updating Mypy, because when I played with it on my machine it worked, it's only the Mypy tests that failed.

@charlesbvll charlesbvll mentioned this pull request Jan 10, 2023
Merged
@charlesbvll charlesbvll changed the title Upgrade to Poetry 1.3.1 Upgrade to Poetry 1.3.2 Jan 10, 2023
@danieljanes danieljanes enabled auto-merge (squash) January 10, 2023 18:50
@danieljanes danieljanes merged commit c961bc7 into main Jan 10, 2023
@danieljanes danieljanes deleted the poetry-131 branch January 10, 2023 18:53
tanertopal added a commit that referenced this pull request Jan 12, 2023
@tanertopal
Merge branch 'main' into telemetry_code
43b685c 
* main:
  Fixes colab links (#1560)
  Updates Ray to 2.2.0 and fixes Mypy errors (#1555)
  Upgrade to Poetry 1.3.2 (#1549)
  Add FedAvg MNIST Baseline to README (#1552)
  Fix badge on README (#1553)
  Flower Baseline: FedAvg MNIST (#1497)
  Fix mt-pytorch example (#1545)
  Upgrade Poetry to 1.2.2 (#1547)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@pedropgusmao pedropgusmao Awaiting requested review from pedropgusmao

@jafermarq jafermarq Awaiting requested review from jafermarq jafermarq is a code owner

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesbvll @danieljanes