Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate requirements.txt to sync with pyproject.toml automatically #1873

Merged
merged 33 commits into from May 24, 2023

Conversation

danielnugraha
Copy link
Contributor

@danielnugraha danielnugraha commented May 15, 2023

Created a script that generates the requirements.txt from pyproject.toml, add a test to ensure the requirements.txt is updated whenever pyproject.toml dependencies changes, and add pip installation info to all examples readme.md.

dev/generate-requirements-txt.sh Outdated Show resolved Hide resolved
dev/generate-requirements-txt.sh Outdated Show resolved Hide resolved
@danieljanes danieljanes changed the title Auto-Generate requirements.txt to Sync With pyproject.toml Automatically Auto-generate requirements.txt to sync with pyproject.toml automatically May 16, 2023
danieljanes
danieljanes previously approved these changes May 16, 2023
danieljanes
danieljanes previously approved these changes May 17, 2023
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@tanertopal
Copy link
Member

@danielnugraha I fixed a small issue in my last commit. Lgtm and can be merged as soon as the merge conflict is resolved.

@tanertopal tanertopal merged commit 9baf179 into main May 24, 2023
10 checks passed
@tanertopal tanertopal deleted the requirements-txt-from-pyproject branch May 24, 2023 11:42
tanertopal added a commit that referenced this pull request Jun 27, 2023
* main: (314 commits)
  Fix D401 First line of docstring should be in imperative mood (#1924)
  Fix D105 Missing docstring in magic method (#1923)
  Fix D202 No blank lines allowed after function docstring (#1920)
  Fix a minor typo in the documentation (#1922)
  Fix docformatter docstrings (#1919)
  Add SecAggMsg field to Task Message (#1893)
  Ignore typing for Ray to fix CI (#1925)
  Update `mypy` to 1.3.0 and fix typing issues (#1877)
  Upgrade black and docformatter, format ipynb (#1902)
  Updated minor error on the documentation, (3rd config dict print) instead of batch_size prints 2 to local_epochs prints 2 (#1903)
  Avoid CI job to marked as failure if requirements.txt check fails (#1906)
  Make check-requirements-txt.sh optional (#1905)
  Add default address for grpc-rere (#1900)
  Update docs dependencies, fix warnings (#1899)
  Add quickstart iOS documentation (#1897)
  Auto-generate requirements.txt to sync with pyproject.toml automatically (#1873)
  Fix updated formatting (#1890)
  Fix code documentation in aggregate_krum() (#1887)
  Remove redundant warning check for strategies subclassing FedAvg (#1855)
  Reformat server for FedBuff (#1888)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants