Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix D202 No blank lines allowed after function docstring #1920

Merged
merged 6 commits into from Jun 14, 2023

Conversation

adam-narozniak
Copy link
Member

@adam-narozniak adam-narozniak commented Jun 13, 2023

Fix D202 [*] No blank lines allowed after function docstring

Order of the PR merges: (only after the first PR is merged into this should the next be reviewed. It's only for the easiness of the review process - the same fixes are in a single PR, diffs easily understandable)

  1. Fix docformatter docstrings #1919
  2. This PR
  3. Fix D105 Missing docstring in magic method #1923
  4. Fix D401 First line of docstring should be in imperative mood #1924
  5. Fix D404 First word of the docstring should not be "This" #1926
  6. Fix D205 D209 #1928
  7. Fix D102 Missing docstring in public method in code #1929
  8. Fix D102 Missing docstring in public method in tests #1933
  9. Fix flake8 noqa #1934
  10. Fix the docstrings of the strategies #1938
  11. Add Ruff linter for docstring checks #1939 (Ruff docstrings saga ends here)

@adam-narozniak adam-narozniak changed the title Fix docstrings Ruff Fix D202 No blank lines allowed after function docstring Jun 14, 2023
@adam-narozniak adam-narozniak marked this pull request as ready for review June 14, 2023 11:16
@adam-narozniak adam-narozniak enabled auto-merge (squash) June 14, 2023 11:16
@adam-narozniak adam-narozniak merged commit 7692f99 into main Jun 14, 2023
10 checks passed
@adam-narozniak adam-narozniak deleted the fix-docstrings-ruff branch June 14, 2023 12:12
tanertopal added a commit that referenced this pull request Jun 27, 2023
* main: (314 commits)
  Fix D401 First line of docstring should be in imperative mood (#1924)
  Fix D105 Missing docstring in magic method (#1923)
  Fix D202 No blank lines allowed after function docstring (#1920)
  Fix a minor typo in the documentation (#1922)
  Fix docformatter docstrings (#1919)
  Add SecAggMsg field to Task Message (#1893)
  Ignore typing for Ray to fix CI (#1925)
  Update `mypy` to 1.3.0 and fix typing issues (#1877)
  Upgrade black and docformatter, format ipynb (#1902)
  Updated minor error on the documentation, (3rd config dict print) instead of batch_size prints 2 to local_epochs prints 2 (#1903)
  Avoid CI job to marked as failure if requirements.txt check fails (#1906)
  Make check-requirements-txt.sh optional (#1905)
  Add default address for grpc-rere (#1900)
  Update docs dependencies, fix warnings (#1899)
  Add quickstart iOS documentation (#1897)
  Auto-generate requirements.txt to sync with pyproject.toml automatically (#1873)
  Fix updated formatting (#1890)
  Fix code documentation in aggregate_krum() (#1887)
  Remove redundant warning check for strategies subclassing FedAvg (#1855)
  Reformat server for FedBuff (#1888)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants