refactor(examples) Update Flower example for variational autoencoder with PyTorch #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chongshenng
changed the title
chongshenng
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
jafermarq
reviewed
Aug 13, 2024
There was a problem hiding this comment.
Looks almost ready!
Just a couple of comments below. Also, should we rename the directory to just federated-variatonal-autoencoder (i.e. dropping the pytorch-)? if you think it's good, we'll also need to update its URL in the top-level README.md and probably define a redirect in doc/source/conf.py.
examples/pytorch-federated-variational-autoencoder/pyproject.toml
Outdated
Show resolved
Hide resolved
examples/pytorch-federated-variational-autoencoder/fedvaeexample/task.py
Outdated
Show resolved
Hide resolved
examples/pytorch-federated-variational-autoencoder/fedvaeexample/task.py
Outdated
Show resolved
Hide resolved
I think we should do the renaming/restructuring after all the examples have been migrated? It'll be one focused PR and we can iterate on the restructuring only. |
jafermarq
reviewed
Aug 13, 2024
jafermarq
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?