Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct num_examples calculation #909

Merged
merged 2 commits into from
Nov 25, 2021
Merged

correct num_examples calculation #909

merged 2 commits into from
Nov 25, 2021

Conversation

mariaboerner1987
Copy link
Contributor

  • change num_examples from len(trainloader) to len(trainset)
  • update Pytorch: From centralized to federated example
  • update Pytorch quickstarter
  • update doc (Pytorch: from centralized to federated)
  • update doc (Pytorch quickstarter)

danieljanes
danieljanes requested changes Nov 24, 2021
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few minor changes required to get this merged.

doc/source/example-pytorch-from-centralized-to-federated.rst Outdated Show resolved Hide resolved
doc/source/example-pytorch-from-centralized-to-federated.rst Show resolved Hide resolved
examples/pytorch_from_centralized_to_federated/cifar.py Show resolved Hide resolved
examples/pytorch_from_centralized_to_federated/client.py Outdated Show resolved Hide resolved
@danieljanes danieljanes merged commit a47cf6b into main Nov 25, 2021
@danieljanes danieljanes deleted the pytorch_numexamples branch November 25, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariaboerner1987 @danieljanes